Commit 146aac96 authored by Verena Praher's avatar Verena Praher
Browse files

add remarks/todos to vgg_basic

parent f02c5d32
...@@ -114,6 +114,12 @@ class MultiTagger(pl.LightningModule): ...@@ -114,6 +114,12 @@ class MultiTagger(pl.LightningModule):
return yy/frames_to_process return yy/frames_to_process
def training_step(self, data_batch, batch_nb): def training_step(self, data_batch, batch_nb):
# TODO: this is not doing a backward pass?? something like this:
# self.optimizer.zero_grad()
# loss.backward()
# self.optimizer.step()
x, y = data_batch x, y = data_batch
y_hat = self.forward_full_song(x, y) y_hat = self.forward_full_song(x, y)
y = y.float() y = y.float()
...@@ -136,7 +142,7 @@ class MultiTagger(pl.LightningModule): ...@@ -136,7 +142,7 @@ class MultiTagger(pl.LightningModule):
'rocauc':avg_auc} 'rocauc':avg_auc}
def configure_optimizers(self): def configure_optimizers(self):
return [torch.optim.Adam(self.parameters(), lr=0.02)] return [torch.optim.Adam(self.parameters(), lr=0.02)] # TODO: isn't that lr too big?
@pl.data_loader @pl.data_loader
def tng_dataloader(self): def tng_dataloader(self):
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment