Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
Shreyan Chowdhury
moodwalk
Commits
146aac96
Commit
146aac96
authored
Sep 06, 2019
by
Verena Praher
Browse files
add remarks/todos to vgg_basic
parent
f02c5d32
Changes
1
Hide whitespace changes
Inline
Side-by-side
models/vgg_basic.py
View file @
146aac96
...
...
@@ -114,6 +114,12 @@ class MultiTagger(pl.LightningModule):
return
yy
/
frames_to_process
def
training_step
(
self
,
data_batch
,
batch_nb
):
# TODO: this is not doing a backward pass?? something like this:
# self.optimizer.zero_grad()
# loss.backward()
# self.optimizer.step()
x
,
y
=
data_batch
y_hat
=
self
.
forward_full_song
(
x
,
y
)
y
=
y
.
float
()
...
...
@@ -136,7 +142,7 @@ class MultiTagger(pl.LightningModule):
'rocauc'
:
avg_auc
}
def
configure_optimizers
(
self
):
return
[
torch
.
optim
.
Adam
(
self
.
parameters
(),
lr
=
0.02
)]
return
[
torch
.
optim
.
Adam
(
self
.
parameters
(),
lr
=
0.02
)]
# TODO: isn't that lr too big?
@
pl
.
data_loader
def
tng_dataloader
(
self
):
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment